Repository navigation
Keep connections in their workspace across one-click connects - #310
Merged
Merged
Conversation
Provider, Docker, local-server and D1 connects build a fresh row on every connect. A new one ignored the active workspace and landed in Personal, and writing one over a saved row dropped its workspace, colour and group. - upsertConnection files a new row under the workspace on screen and keeps workspaceId, color and group unless the caller names them. Sync writes with `exact` so the remote record stays the truth. - The workspace follows the connection that opens, so the sidebar never lists a workspace without the open database. - The sidebar list includes discovered (Docker, machine, studio) rows, the same rows the dialog lists and the switcher counts. - Workspace switcher: sidebar tokens, a hairline frame so it reads as the picker rather than the first row, a focus ring, mono counts and a spoken "N connections" label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider, Docker and local one-click connects filed new connections outside the active workspace, so they vanished from the rail after a switch. They now land in the workspace that was active when I connected, and the switcher counts them there.
connections.js: file new and re-saved connections into the active workspaceWorkspaceSwitcher.svelte: counts follow the filed workspaceconnections.test.jsrelease:skip: it ships with the 3.1.0 bump in the hard-cases PR.