Skip to content

Keep connections in their workspace across one-click connects - #310

Merged
broisnees merged 1 commit into
nightlyfrom
fix/workspace-filing
Nov 20, 2026
Merged

broisnees merged 1 commit into
nightlyfrom
fix/workspace-filing

Conversation

@broisnees

Copy link
Copy Markdown
Collaborator

Provider, Docker and local one-click connects filed new connections outside the active workspace, so they vanished from the rail after a switch. They now land in the workspace that was active when I connected, and the switcher counts them there.

  • connections.js: file new and re-saved connections into the active workspace
  • WorkspaceSwitcher.svelte: counts follow the filed workspace
  • Tests in connections.test.js

release:skip: it ships with the 3.1.0 bump in the hard-cases PR.

Provider, Docker, local-server and D1 connects build a fresh row on every
connect. A new one ignored the active workspace and landed in Personal, and
writing one over a saved row dropped its workspace, colour and group.

- upsertConnection files a new row under the workspace on screen and keeps
  workspaceId, color and group unless the caller names them. Sync writes
  with `exact` so the remote record stays the truth.
- The workspace follows the connection that opens, so the sidebar never
  lists a workspace without the open database.
- The sidebar list includes discovered (Docker, machine, studio) rows, the
  same rows the dialog lists and the switcher counts.
- Workspace switcher: sidebar tokens, a hairline frame so it reads as the
  picker rather than the first row, a focus ring, mono counts and a
  spoken "N connections" label.
@broisnees broisnees added the release:skip Merge into nightly without a version bump (docs, CI, chores) label Nov 20, 2026
@broisnees
broisnees merged commit 3012a3b into nightly Nov 20, 2026
1 check passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release:skip Merge into nightly without a version bump (docs, CI, chores)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant