Repository navigation
Fix the stroke-bin PKGBUILD for v3 .debs - #309
Merged
Merged
Conversation
…roke Since 2.20 the .deb ships /usr/bin/stroke and stroke.png, so the unconditional mv of app failed and yay -S stroke-bin broke for everyone. The renames now run only when the old names are there. pkgrel is a template field, and aur.yml republishes a released version with a higher pkgrel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 2.20 the
.debalready ships/usr/bin/strokeandstroke.png. The template's unconditionalmv "$pkgdir/usr/bin/app" ...therefore failed, which brokeyay -S stroke-binandinstall.shon Arch for v3.0.0.appnames exist.pkgrelis a template field:release.ymlfills in 1.aur.yml: Republish to the AUR for a tag that's already released, with a higherpkgrel. After merging, I run it withv3.0.0and pkgrel2.Tested: I ran
package()under an ERR trap on the real v3.0.0.deb(shipsstroke) and the 2.3.0.deb(shipsapp). Both end with/usr/bin/stroke,stroke.pngicons, andExec=stroke,Icon=strokeandCategories=Development;Database;in the desktop file.