Repository navigation
Fix sync failing with "Unknown record kind: library" - #291
Merged
Merged
Conversation
The sync engine and the server both know five record kinds, but the Rust encryption step still listed three, so the first saved query or library item failed every push with "Unknown record kind". List all five, and add a test that keeps the JS and Rust lists the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync failed on every OS once a saved query or library item existed: the JS engine and stroke-web accept
queryandlibrary, butKINDSinsrc-tauri/src/sync.rsstill listed three kinds, soencrypt_plainrefused the push.KINDSnow lists all five.KINDSinengine.js.