Repository navigation
Lazy data grid, native Wayland with X11 fallback, whole-table exports, faster Nightly builds - #285
Merged
Merged
Conversation
…, faster Nightly builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startup. The data grid (~400KB) left the startup bundle: it loads when a table first renders, and is fetched as soon as a connection opens (and on idle) so it's in memory before rows arrive. PaneSnapshot, which imported it statically, is lazy too. Everything loaded at launch: 2,488KB → 2,191KB. Checked in the real app: a table opens and renders.
Native Wayland by default (Linux).
display_backend.rspicks the backend before GTK starts. A Wayland launch leaves a marker; the page's first finished screen (reveal_window) clears it. If the next launch still finds it, that launch and every later one use X11. A release-build Wayland launch that hasn't drawn after 25s restarts itself on X11 straight away (the #112-style EGL abort leaves the window hidden).STROKE_X11=1forces X11;STROKE_WAYLAND=1forces Wayland and forgets the fallback; a user's ownGDK_BACKENDwins. The AppImage hook no longer hard-sets x11. Checked: marker created then cleared on first paint; a leftover marker switches to X11 (use-x11);STROKE_WAYLAND=1clears it. Not checked on a real Wayland session here.Exports. Paged mode exported only the page on screen ("Exported 100 rows" of a 5,000-row table); an export with no selection now reads the whole table, with its filters and sort. Large CSV/JSON exports were built twice (the chunked build was discarded by a stray
content = ''outside an else). The export.js TODOs are gone: a note in the file would corrupt it; the toast is the place.Nightly CI. With every dependency cached (full cache match), ~9 of the ~11 build minutes were the release profile's fat LTO on one codegen unit. Nightly builds use thin LTO and 16 codegen units (env overrides in nightly.yml); Stable keeps fat LTO.
cargo build, svelte-check, design-lint and the 1800 tests pass.