Repository navigation
Load Settings, the command palette and one-off dialogs on first use - #280
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startup loaded seven components that never show at launch: Settings (75KB, plus the theme builder inside it), the command palette (42KB), AI settings (28KB), and the create-table, import, share and Docker dialogs.
Each now mounts the first time it opens and stays mounted after (so closing keeps its exit animation). They're also fetched once the window is idle, palette and Settings first, so the first open is still instant. The share dialog mounts when a share is requested, since it opens itself from that store.
Measured (vite build):
The 405KB data grid still loads at launch: a restored session opens a table right away, so deferring it would only move the wait.
Checked in the real app (WebKitGTK): Settings opens, Esc closes it, the palette opens, closes and reopens. svelte-check, design-lint, vite build and the 1799 tests pass.