Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the echarts < 6.1.0 XSS advisory (
npm auditno longer lists echarts). Replaces #14.echarts^5.6.0 → ^6.1.0.echarts-wordcloud2.1.0 still declaresecharts ^5as a peer, so an override points it at the app's echarts; the word cloud renders on 6.v5theme (ECHARTS_THEMEin chart-utils, loaded withecharts/theme/v5in EChartPanel, ChartView, AiChartRenderer and ChoroplethChart), so nothing changes on screen.Checked: rendered all 35 chart types from
buildOptionwith sample data on echarts 5, on 6, and on 6 with the v5 theme. 6 + v5 matches 5 everywhere except the sunburst, whose segments take the palette in a different order; no errors on any type. vite build, svelte-check, design-lint and the 1799 tests pass.