Repository navigation
Don't self-update Scoop installs on Windows; show scoop update stroke instead - #278
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same class of bug as #277, on Windows. Scoop unpacks the NSIS setup into its own folder, so a Scoop install reads as an NSIS install. Installing an update from the app ran the setup, which put a second, separate copy under %LOCALAPPDATA% and left Scoop's copy on the old version.
A Scoop install (
\\scoop\\apps\\in the path, or under a customSCOOP/SCOOP_GLOBALroot) is now package-managed: the update dialog showsscoop update strokewith Copy instead of installing. The apply-on-quit check uses the same detection.macOS is not affected: it updates in place, Homebrew included; the cask gets
auto_updates truein the tap sobrew upgradeleaves it to the app.cargo check(Linux), svelte-check and tests pass; the Windows code is compiled by the Windows build in CI. The path test was run standalone (default root, non-Scoop path, custom SCOOP root).