Skip to content

Don't self-update AUR, .deb and .rpm installs; show the package manager command instead - #277

Merged
broisnees merged 1 commit into
nightlyfrom
updater-package-managed
Nov 17, 2026
Merged

broisnees merged 1 commit into
nightlyfrom
updater-package-managed

Conversation

@broisnees

Copy link
Copy Markdown
Collaborator

On Arch, updating from inside the app failed with "invalid updater binary format".

The AUR packages unpack the .deb, so the installed binary reports itself as a .deb install. The release feed ships only the AppImage for Linux, so the updater downloaded the AppImage and handed it to its .deb installer, which rejected it. The same happens for a .deb or .rpm installed from the website. And those files belong to the package manager anyway.

  • updates.rs: a Linux install that isn't a running AppImage is package-managed. UpdateInfo gains manual and manualCommand (yay -Syu stroke-nightly-bin or yay -Syu stroke-bin, read from pacman's local db). update_download and update_restart refuse with a plain message, and nothing is ever staged for such an install.
  • Update dialog: for a package-managed install it says the update comes from the package manager, shows the command with Copy (AUR) or a Download page button (.deb/.rpm), and hides the "install automatically" checkbox. Background checks never auto-download for it.
  • The sign-in screen's update check shows the same.

cargo check, svelte-check, design-lint and the 1799 tests pass.

@broisnees
broisnees merged commit 302022d into nightly Nov 17, 2026
1 check passed
@broisnees
broisnees deleted the updater-package-managed branch November 17, 2026 06:04
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant