Repository navigation
Keep the title bar's spacing fixed when zoomed on Linux - #274
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zooming the app on Linux spread the title bar out: the menu labels (File, Edit, View...) stayed small while the padding and gaps around them grew with every zoom step.
The title bar counter-zooms itself with CSS
zoom: 1/scaleso it stays the size of a native title bar. Its text uses px variables, which every engine zooms back. Its padding and gaps are Tailwind spacing, which is rem, and WebKitGTK does not applyzoomto rem lengths, so on Linux those stayed at the zoomed size. Inside the bar the spacing unit is nowcalc(4px * var(--app-scale)), which zooms back to 4px in WebKitGTK, WebView2 and WKWebView alike.Reproduced and checked in the real app (WebKitGTK, Xvfb): at 112% the menu row now lines up with 100%. design-lint and the 1799 tests pass.