Repository navigation
Check for updates from the sign-in and trial screens; open title bar menus over the welcome tour - #273
Merged
Conversation
…menus over the welcome tour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for updates before sign-in. The sign-in and trial-expired screens replace the whole app, update dialog included, so a build that couldn't get past sign-in had no way to fetch its fix. Both footers now show the version and a Check for updates button (
GateUpdateCheck.svelte): checking, up to date, available (Update and restart), download progress (a realprogressbar), ready (Restart to install) and error (Retry). Every state is announced through one polite live region.Title bar menus during the welcome tour. The tour sat at z-index 200, over the title bar's menus (z-50/60), so the workspace, account and File/Edit menus opened behind it and looked dead. The tour is now z-[45]: over the app, under menus, dialogs and popovers.
Checked in a browser render (footer idle and error states). svelte-check, design-lint and the 1799 tests pass.