Repository navigation
Let the AppImage run on native Wayland with STROKE_WAYLAND=1 - #270
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing Nightly 2.16.8 on Arch (Omarchy, Hyprland, AMD): linuxdeploy's GTK hook hard-sets
GDK_BACKEND=x11, so the AppImage always runs through XWayland andGDK_BACKEND=waylandon the command line is ignored. Native Wayland rendered fine on that machine once the hook let it.X11 stays the default, since it is the fallback for the WebKit EGL_BAD_ALLOC crash some Wayland setups hit. The repack step in
scripts/appimage-strip-host-libs.sh(already run for #112) now rewrites the hook line soSTROKE_WAYLAND=1selectsGDK_BACKEND=wayland. The README says so.Checked: the rewritten hook gives x11 by default, wayland with
STROKE_WAYLAND=1, and x11 with onlyGDK_BACKEND=waylandset (so Hyprland's globalGDK_BACKENDdoesn't flip everyone). The full repack runs in the nightly build; I'll verify the AppImage on the Arch machine after it.