Repository navigation
Report 'charging starts in a moment' after releasing macOS's limit - #83
Merged
Merged
Conversation
…elperBuild 34 macOS took 24-60 s to start charging after eWiz released its charge limit, and the panel said "Plugged in, not charging" throughout. For two minutes after a release, a battery on the cable that isn't charging yet is reported as settling, and the settling wording no longer assumes a wake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On a Mac that limits through macOS's charge limit, switching eWiz's limit off left the battery not charging for 24–60 s while macOS started up again. The panel said "Plugged in, not charging" the whole time, which read as the switch having failed.
Changes
pauseReason = "settling".HelperBuild33 → 34.ChargeDisplay. The settling wording is no longer wake-specific:Verified
Helper build 34 on the affected Mac: limit off → the app showed settling within 1 s → charging started 24 s later.
swift test: 287 pass.