Resolve config and temp paths independently of the working directory - #93
Open
dwaycik wants to merge 1 commit into
Open
Resolve config and temp paths independently of the working directory#93dwaycik wants to merge 1 commit into
dwaycik wants to merge 1 commit into
Conversation
PATH_TO_DEFAULT_CONFIG was 'src/epomakercontroller/configs/default.json', a path that only exists inside a source checkout. An installed copy raises FileNotFoundError from load_main_config() when run from anywhere else, which includes any desktop launcher or systemd service. get_main_config_directory() used Path(os.path.abspath(os.curdir)) -- assigned to a variable named home_dir -- so the config lived in whatever directory the process started in. 0.0.8 used Path.home(). TMP_FOLDER was './.epomaker_controller' and constants.py ran os.mkdir on it at import time, creating a directory in the caller's working directory as a side effect of importing the package. Moved under the system temp directory and created where it is actually written.
kbrddestroyer
self-requested a review
August 2, 2026 08:39
kbrddestroyer
requested changes
Aug 2, 2026
kbrddestroyer
left a comment
kbrddestroyer
left a comment
Collaborator
There was a problem hiding this comment.
As commented, I'd suggest storing configs inside project directory. Leave a comment if you have any other options
|
|
||
| def get_main_config_directory() -> Path: | ||
| home_dir = Path(os.path.abspath(os.curdir)) | ||
| home_dir = Path.home() |
Collaborator
There was a problem hiding this comment.
Well, if we're working with home directory I'd rather pick .config/ folder. But as for me, the best way would be to resolve project install directory and work inside it.
Maybe something like Path(__file__).parent() would work here?
| # Create temp folder in project path on Linux as well | ||
| if not os.path.exists(TMP_FOLDER): | ||
| os.mkdir(TMP_FOLDER) | ||
| # Created on demand by whatever writes there, rather than as an import side |
Collaborator
There was a problem hiding this comment.
Fair enough, but I think this comment is not necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three related paths in
configs/constants.pyresolve against the current working directory, so an installed copy only works when run from a source checkout.1.
PATH_TO_DEFAULT_CONFIGcannot be found after installThat path only exists inside a checkout. From anywhere else:
This affects any desktop launcher or systemd service, where the working directory is the home directory. Now resolved against
__file__, where the file is actually installed.2. The config directory follows the working directory
The variable is named
home_dirbut holdsos.curdir, so each working directory gets its own.epomaker-controller/. 0.0.8 usedPath.home(); restored.3.
constants.pycreates a directory at import timeImporting the package creates a directory in the caller's working directory. Moved under
tempfile.gettempdir(), and created bygenerate_udev_rule()— the only thing that writes there — so behaviour is unchanged.Found while building a GTK front end against 0.0.9; I currently patch these at import to make a systemd user service work.