Clamp GIF frame dimensions to one alignment block - #92
Open
dwaycik wants to merge 1 commit into
Open
Conversation
best_gif_dimensions() floors each axis to a multiple of 64, which drives the short axis of a wide or tall source to zero: an 800x200 GIF fits to 162x41, and floor(41 / 64) * 64 == 0. Zero then passes the per_frame_size % 4096 guard in __init__, because 0 % 4096 == 0, so the upload proceeds and sends an empty frame rather than raising. Clamping to a single 64px block keeps every result 4K-aligned: 64a * 64b * 2 == 8192ab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
best_gif_dimensions() floors each axis to a multiple of 64, which drives the short axis of a wide or tall source to zero:
An 800x200 GIF fits to 162x41, and
floor(41 / 64) * 64 == 0.Zero then passes the
per_frame_size % 4096guard in__init__, because0 % 4096 == 0, so the upload proceeds and sends an empty frame rather than raising the ValueError that guard exists to raise.Clamping to a single 64px block keeps every result 4K-aligned, since any pair of multiples of 64 satisfies it:
64a * 64b * 2 == 8192ab.Found while building a GTK front end against 0.0.9. Thanks for the GIF work — the multi-frame protocol is the reason the RT100 screen is usable on Linux at all.