Fix WinterTC lint violation in private-preview branch#2721
Closed
jar-stripe wants to merge 1 commit into
Closed
Conversation
…ificationHandler Buffer is a Node.js-specific global. Since Buffer extends Uint8Array, this is a compatible change — callers passing Buffer still work. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
jar-stripe
requested review from
Copilot and
xavdid
and removed request for
a team and
Copilot
jar-stripe
changed the title
jar-stripe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
#2715 added a lint rule to ensure we conform to the WinterTC Minimum Web Platform API standard. The EventNotificationHandler class in the private-preview uses
Bufferwhich is not allowed by these rules.What?
BufferwithUint8Arrayinsrc/StripeEventNotificationHandler.tsSee Also