Add remaining FlixelTweenTypes LOOPING, PINGPONG and BACKWARD by jfsaaved · Pull Request #58 · stringdotjar/flixelgdx

jfsaaved · 2026-03-07T06:57:02Z

Issue: #38

Add LOOPING, PINGPONG, and BACKWARD to FlixelTweens
Add active variable
Add delayToUse variable
Add waitingForRestart variable

Description

The goal is to include the BACKWARD, LOOPING and PINGPONG tween types to allow further control of the tweening system.

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Refactor / Optimization

Checklist

My PR targets the develop branch, not master/main.
My code follows the code style of this project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
My changes pass all automated build checks.
I have updated the documentation accordingly (if applicable).
I have added tests that prove my fix is effective or that my feature works.

Screenshots / Evidence (if applicable)

PINGPONG

LOOPING

BACKWARD

- AddLOOPING, PINGPONG, and BACKWARD to FlixelTweens - Add active variable - Add delayToUse variable - Add waitingForRestart variable

- Fix FlixelPropertyTween math for new value - Revert changes on FlixelTween update - Add begind for snapshotarray

…nto feature/sub-issue-38-remaining_tweens

stringdotjar · 2026-03-07T13:29:11Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTween.java

  /** Default constructor for pooling purposes. */
-  protected FlixelTween() {}
+  protected FlixelTween() {
+  }


Please revert the brace back to be on one line

stringdotjar · 2026-03-07T13:31:42Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTween.java

+    var type = tweenSettings.getType();
+
+    if (type.equals(FlixelTweenType.LOOPING) || type.equals(FlixelTweenType.PINGPONG)) {
+      if (type.equals(FlixelTweenType.PINGPONG))


Please put the brace on the same line for consistency

stringdotjar · 2026-03-07T13:33:09Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTween.java

+        onComplete.run(this);
+      }
+      // If it's not PERSIST, remove tween from activeTweens and set to active = false
+      if (type.equals(FlixelTweenType.ONESHOT) || type.equals(FlixelTweenType.BACKWARD) && manager != null)


Please put the brace on the same line for consistency

stringdotjar · 2026-03-07T14:00:36Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTween.java


-  /** Is {@code this} tween currently active? */
-  public boolean running = false;
+  /** Is {@code this} tween active */


Please add a question mark at the end for proper punctuation

stringdotjar · 2026-03-07T14:00:49Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTween.java

+  /** Is {@code this} tween active */
+  protected boolean active = false;
+
+  /** Is {@code this} tween waiting for a restart */


Please add a question mark at the end for proper punctuation

stringdotjar · 2026-03-07T14:13:10Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTween.java

    return globalManager;
  }

-  public FlixelTweenManager getManager() {


Please revert this back

stringdotjar · 2026-03-07T14:18:40Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTween.java

+    return waitingForRestart;
  }

  public FlixelTween setManager(FlixelTweenManager newManager) {


Nice j*b moving the remove logic to the manager class, although you can make this method simpler using the @NotNull annotation, so that way you don't have to do if (newManager == null)

stringdotjar · 2026-03-07T14:19:41Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTweenManager.java

-      FlixelTween tween = tweens[i];
-      if (tween == null) {
+    FlixelTween[] items = activeTweens.begin();
+    ArrayList<FlixelTween> finishedTweens = new ArrayList<>();


Do not create new objects inside the update loop, as that will cause the framerate to stutter. You can condense this into a single for loop without having to create a new ArrayList every frame

stringdotjar · 2026-03-07T14:22:45Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTweenManager.java

    activeTweens.end();
  }

+  /**


Please do the following:

Add proper grammar in the Javadoc (a sentence ends with a period) and be a little more descriptive. It should read as (Remove an {@link FlixelTween} from {@code this} manager. Note that when the tween is removed, it will call {@link FlixelTween#destroy} and it can no longer be used.)

Replace the typo Boolean with boolean, as we are not expecting an object!

Add braces to the if (tween == null) statement. We typically only need to use one-line if statements if we need to do multiple checks in an area, in which one liners would become more readable rather than braces

stringdotjar · 2026-03-07T14:37:42Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTween.java

+    }
+  }
+
+  /**


Please fix Javadoc grammar (add a period) and put brace on same line as the method for consistency

stringdotjar · 2026-03-07T14:44:56Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTweenManager.java

+    return tween;
+  }
+
+  /**


As said in the comment for removeTween(), please fix the Javadoc and formatting + be a little more descriptive

Also, rename it to simply addTween(FlixelTween tween), as it will still imply the same idea

stringdotjar · 2026-03-07T15:21:39Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTweenManager.java

+    activeTweens.removeValue(tween, true);
+
+    if (destroy) {
+      tween.destroy();


Remove this line here, as when you call tweenPool.free(), it automatically calls reset(), in which inside of FlixelTween.reset(), it should call destroy()

stringdotjar

Nice job! There's just a few things to do left you need to do before I merge it into the codebase:

Fix your formatting to match what's in the .editorconfig file. Remember, we want the codebase to look like it was written by a single person
Update the Javadocs and your comments as stated in the GitHub comments I left
When the tween restarts, it goes back to the starting values where the tween started at before the tween started. This should not happen. For example, if a sprite had its x field start at 0f, and it's being tweened to 400f, and it was cancelled and restarted at 200f, it should restart and begin at 200f, not back from 0f. This applies to all tween types
Refactor destroy() to use the reset() method and replace the resetBasic() call in reset() to use destroy(), as we want both methods to do the same thing for backwards compatibility

stringdotjar · 2026-03-07T15:24:04Z

flixelgdx-core/src/main/java/me/stringdotjar/flixelgdx/tween/FlixelTween.java

+    // resetToBasic won't work for LOOPING & PINGPONG, hence removed it and switched vars manually
+    waitingForRestart = false;
+    var type = this.getTweenSettings().getType();
+    if(!type.equals(FlixelTweenType.PINGPONG)) { // If it's PINGPONG use the finish() backward variable instead of resetting it here


Please add spaces after the if keywords

Adding remaining FlixelTweens - LOOPING, PINGPONG, BACKWARD

fb8a9a3

- AddLOOPING, PINGPONG, and BACKWARD to FlixelTweens - Add active variable - Add delayToUse variable - Add waitingForRestart variable

github-project-automation bot added this to FlixelGDX Project Board Mar 7, 2026

github-project-automation bot moved this to 🗒️ Todo in FlixelGDX Project Board Mar 7, 2026

jfsaaved added 4 commits March 7, 2026 06:39

Fix clean up for FlixelTweens

eb23610

Fix FlixelTween BACKWARD, LOOPING, PINGPONG bugs

72e8a3d

- Fix FlixelPropertyTween math for new value - Revert changes on FlixelTween update - Add begind for snapshotarray

FlixelTween Implementation Refactoring

f19bc12

Merge branch 'develop' of https://github.com/stringdotjar/flixelgdx i…

b72244b

…nto feature/sub-issue-38-remaining_tweens

jfsaaved marked this pull request as draft March 7, 2026 12:49

jfsaaved marked this pull request as ready for review March 7, 2026 12:50

jfsaaved added 2 commits March 7, 2026 07:56

ONESHOT & BACKWARD remove tween fix

1433353

Delete MyGame

1eb023c

stringdotjar moved this from 🗒️ Todo to 🏗️ In Progress in FlixelGDX Project Board Mar 7, 2026

stringdotjar reviewed Mar 7, 2026

View reviewed changes

stringdotjar assigned jfsaaved Mar 7, 2026

stringdotjar added enhancement New feature or request core Core logic module of the framework tweening Custom tweening system for adding animations on objects labels Mar 7, 2026

stringdotjar changed the title ~~[WIP] Adding remaining FlixelTweens - LOOPING, PINGPONG, BACKWARD~~ Add remaining FlixelTweens LOOPING, PINGPONG and BACKWARD Mar 7, 2026

stringdotjar changed the title ~~Add remaining FlixelTweens LOOPING, PINGPONG and BACKWARD~~ Add remaining FlixelTweenTypes LOOPING, PINGPONG and BACKWARD Mar 7, 2026

stringdotjar reviewed Mar 7, 2026

View reviewed changes

stringdotjar requested changes Mar 7, 2026

View reviewed changes

stringdotjar reviewed Mar 7, 2026

View reviewed changes

stringdotjar added the needs changes This pull request needs changes before it can be merged label Mar 7, 2026

stringdotjar moved this from 🏗️ In Progress to Needs Improvements in FlixelGDX Project Board Mar 8, 2026

stringdotjar marked this pull request as draft March 8, 2026 20:50

+                  }
+                }
+                /**

Uh oh!

Conversation

jfsaaved commented Mar 7, 2026 • edited by stringdotjar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Checklist

Screenshots / Evidence (if applicable)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stringdotjar Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stringdotjar Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stringdotjar Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stringdotjar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jfsaaved commented Mar 7, 2026 •

edited by stringdotjar

Loading

stringdotjar Mar 7, 2026 •

edited

Loading

stringdotjar Mar 7, 2026 •

edited

Loading

stringdotjar Mar 7, 2026 •

edited

Loading