assert: show diff for one unmatched struct pair - #1960
Open
fzlzjerry wants to merge 1 commit into
Open
Conversation
Append the existing unified diff when each list has exactly one unmatched non-nil struct or struct pointer of the same type. Keep list matching and all other diagnostics unchanged. Fixes stretchr#1376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a field-level diff when
ElementsMatchleaves one unmatched struct on each side, following the narrow case discussed in #1376.Changes
For example, a boolean field change now includes:
Validation
Full
go test -race -count=1 ./...passes on Go 1.17.13, 1.23.12, 1.25.14, 1.26.8 and 1.27.1.The repository's generation, formatting and vet scripts pass on Go 1.26.8 and 1.27.1; regeneration produces no changes.
A 500-case before/after comparison preserves every matching result. The 400 non-target diagnostic reports are byte-identical; the remaining 100 single-pair cases gain the field diff.
The unchanged All builds workflow on the fork passed all 12 jobs on this commit.
Related issues
Closes #1376.