assert: accept full HTTP success and redirect status classes - #1959
Open
jakezwang wants to merge 1 commit into
Open
assert: accept full HTTP success and redirect status classes#1959jakezwang wants to merge 1 commit into
jakezwang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
HTTPSuccessandHTTPRedirectrejecting valid status codes such as 207 and 308.Changes
Motivation
A handler returning 207 Multi-Status, 208 Already Reported, or 226 IM Used currently fails
HTTPSuccess; 308 Permanent Redirect failsHTTPRedirect. HTTP status classes are defined by the first digit (RFC 9110).Validation: the new regression fails on the previous code and passes with this fix.
go test -v -race -count=1 ./...,.ci.gogenerate.sh,.ci.gofmt.sh, and.ci.govet.shpass with Go 1.26.4.Related issues
None; reproduced against current master.