Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid copying the entire call history slice in
AssertNumberOfCallsby iterating overm.Callsdirectly.Changes
m.Callsdirectly by index inAssertNumberOfCalls, eliminating slice copy allocations (m.calls()) and per-iterationCallstruct copying.Benchmark_Mock_AssertNumberOfCallsinmock/mock_test.goto measure and track assertion performance.Motivation
AssertNumberOfCallscurrently callsm.calls(), which copies the entire call history slice into a newly allocated slice before counting entries with a matching method name.AssertNumberOfCallsalready acquiresm.mutex.Lock()at the start and holds it throughout the counting loop, making slice duplication redundant.Directly indexing
m.Callsunder the held mutex significantly improves performance and eliminates slice allocations.Benchmark comparison (Apple M3, Go 1.25.5, 100 recorded calls, 5 runs):
1923 ns/op,18,584 B/op,4 allocs/op508 ns/op,144 B/op,3 allocs/opResult: ~3.8x faster and 99.2% reduction in allocated memory per assertion.
Related issues
Closes #1957