Skip to content

CI: fail incomplete action pin validation #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattjohnsonpint wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

CI: fail incomplete action pin validation #1953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .ci.ghactions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@

set -euo pipefail

# Keep the pipeline's while loop in this shell so status updates survive.
shopt -s lastpipe

declare -A seen
status=0

Expand All @@ -41,8 +44,8 @@ do
fi
seen["$action-$hash-$tag"]=1

if eval "$( curl -s -H "Accept: application/vnd.github+json" \
"https://api.github.com/repos/$action/commits/$tag" | jq -r '.sha == "'"$hash"'"' )"
if curl --fail --silent --show-error -H "Accept: application/vnd.github+json" \
"https://api.github.com/repos/$action/commits/$tag" | jq -e --arg hash "$hash" '.sha == $hash' >/dev/null
Comment on lines +47 to +48

@mattjohnsonpint mattjohnsonpint Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative would be to avoid the GitHub API and jq by checking the remote tag with Git directly.

Suggested change
if curl --fail --silent --show-error -H "Accept: application/vnd.github+json" \
"https://api.github.com/repos/$action/commits/$tag" | jq -e --arg hash "$hash" '.sha == $hash' >/dev/null
if git ls-remote --exit-code "https://github.com/$action.git" \
"refs/tags/$tag" "refs/tags/$tag^{}" |
grep -q "^$hash[[:space:]]"

Let me know which approach you prefer.

then
printf "\e[1;32m%s: %s@%s == %s\e[m\n" "$w" "$action" "$tag" "$hash"
else
Expand Down