mock: document Call.Times behavior when called with zero - #1948
Open
lazerg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document what
Call.Times(0)does.Changes
Call.Timesdoc comment:i=0resets the call to the default behavior of returning at least once, and omittingMock.Onis how you expect no calls at all.Motivation
The doc comment only described the
i>0case, soTimes(0)looked like a way to expect zero calls. It isn't, and a user hit that in #1855. Wording follows @brackendawson's suggestion on the issue.Related issues
Closes #1947