Add investigation notes and root cause for issue #15618#63
Merged
Conversation
Co-authored-by: Laura Wilby <sfc-gh-lwilby-1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #62 (which was already merged before these changes were pushed).
Adds
issues/gh-15618/NOTES.mdwith the full root-cause analysis and refines the workaround explanation inissues/gh-15618/app.py.Root cause (confirmed)
The selectbox widget state is correct ("two"), but
st.selectbox()returns the default option ("one") to the script.validate_and_sync_value_with_optionsvalidates the stored selection by calling the user'sformat_funcon it inside a broadexcept Exception. The stored value is adeepcopyof an instance of the previous rerun's class object (the script redefines the class each run); a dataclass's class-gated__eq__makesx[s]raiseKeyError, which the broad except treats as "value not in options" and resets to index 0.NamedTupleis immune because it uses value-basedtuple.__eq__.Verified via a headless
AppTestmatrix and a monkeypatched trace of the validation helper. SeeNOTES.mdfor details and a suggested fix direction.