Skip to content

add encoding support to the read() method #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BettyJJ wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add encoding support to the read() method #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions st_files_connection/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def _read_csv(path: str | Path, **kwargs) -> pd.DataFrame:
if "connection_name" in kwargs:
kwargs.pop("connection_name")

with self.open(path, "rt") as f:
with self.open(path, "rt", encoding=kwargs.get("encoding")) as f:
return pd.read_csv(f, **kwargs)

@cache_data(ttl=ttl, show_spinner="Running `files.read(...)`.")
Expand All @@ -166,7 +166,7 @@ def _read_json(path: str | Path, **kwargs) -> Any:
if "connection_name" in kwargs:
kwargs.pop("connection_name")

with self.open(path, "rt") as f:
with self.open(path, "rt", encoding=kwargs.get("encoding")) as f:
return json.load(f, **kwargs)

@cache_data(ttl=ttl, show_spinner="Running `files.read(...)`.")
Expand All @@ -175,7 +175,7 @@ def _read_jsonl(path: str | Path, **kwargs) -> pd.DataFrame:
kwargs.pop("connection_name")

kwargs['lines'] = True
with self.open(path, "rt") as f:
with self.open(path, "rt", encoding=kwargs.get("encoding")) as f:
return pd.read_json(f, **kwargs)

# Try to infer input_format from file extension if missing
Expand Down