Repository navigation
Fix obs-filter(s) not rendering - #1809
Open
sandboxcoder wants to merge 1 commit into
Open
sandboxcoder wants to merge 1 commit into
sandboxcoder wants to merge 1 commit into
Conversation
- Add test to verify filters work properly - Now the filter is no longer skipped by obs_source_skip_video_filter() due to the target && effect entries being null. - Asana ticket: https://app.asana.com/1/1083097041131/project/1207748235152481/task/1217844168779754?focus=true All tests pass- ctest --test-dir build -C RelWithDebInfo -R "obs_studio_server_unit_tests::" --output-on-failure
sandboxcoder
force-pushed
the
rno/release-filters
branch
from
October 16, 2026 22:06
f667b47 to
90e2d36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add test to verify filters work properly
Now the filter is no longer skipped by obs_source_skip_video_filter() due to the target && effect entries being null.
Resolve Asana ticket: https://app.asana.com/1/1083097041131/project/1207748235152481/task/1217844168779754?focus=true
Motivation and Context
QA discovered this issue when they applied a grayscale filter to web camera output and it failed to apply. From there, I set a breakpoint inside
color_grade_filter_renderand verified the render pass was being skipped. I notice this issue did not occur in LIVE and isolated issue to obs32 merge because it will not tick a filter that has been removed.How Has This Been Tested?
Now, in Desktop, I can add a filter to an image and it properly renders. Add a test case to validate the filter passes now (but fails when this fix is not present).
Types of changes
Checklist: