Repository navigation
Restore Twitch VOD support in Simple output mode - #1802
Merged
Merged
Conversation
summeroff
approved these changes
Oct 13, 2026
aleksandr-voitenko
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
NodeObs Enhanced Broadcasting still ignores the new Simple-mode setting and uses Advanced VOD configuration.
1 open finding
What changed in this PR
Restores Twitch VOD audio in Simple output mode using source track 2 while preserving mixer routing.
Changes:
- Adds Simple and Enhanced Broadcasting VOD routing.
- Exposes and persists the Simple Twitch VOD setting.
- Expands RTMP audio decoding and routing tests.
| File | Description |
|---|---|
tests/osn-tests/util/rtmp-protocol.ts |
Extracts AAC payload data. |
tests/osn-tests/util/rtmp-assertions.ts |
Builds probeable ADTS audio. |
tests/osn-tests/util/README.md |
Documents VOD test behavior. |
tests/osn-tests/src/test_rtmp_test_server.ts |
Tests AAC payload extraction. |
tests/osn-tests/src/test_osn_streaming_vod.ts |
Tests routing and mixer preservation. |
tests/osn-tests/src/test_nodeobs_simple_vod_settings.ts |
Tests settings visibility and persistence. |
obs-studio-server/source/osn-streaming.hpp |
Removes obsolete mixer state. |
obs-studio-server/source/osn-simple-streaming.hpp |
Defines the fixed VOD mixer. |
obs-studio-server/source/osn-simple-streaming.cpp |
Configures Simple VOD encoding. |
obs-studio-server/source/osn-enhanced-broadcasting-simple-streaming.cpp |
Requests VOD audio for Enhanced Broadcasting. |
obs-studio-server/source/nodeobs_settings.cpp |
Exposes the Simple VOD setting. |
js/module.ts |
Documents VOD routing semantics. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aleksandr-voitenko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore the missing Twitch VOD option in Simple output settings when Enable Advanced Encoder Settings is enabled and the built-in Twitch service is selected.
Motivation and Context
Simple settings omitted VodTrackEnabled, while the streaming implementation still used Soundtrack’s internal track 6. This prevented users from enabling VOD through Simple settings and made audio routing inconsistent with Desktop’s track 2 controls.
Paired with the Desktop change, which initializes VOD routing and preserves source exclusions when saving Simple settings.
How Has This Been Tested?
Types of changes