Fix selective recording in Simple output mode - #1798
Merged
Merged
Conversation
summeroff
approved these changes
Oct 2, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Frame-dimension validation and platform handling in the new integration suite need correction.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Fixes Simple-mode selective recording so saved videos follow recording visibility rather than stream visibility.
Changes:
- Corrects the render mix for HighQuality and HigherQuality presets.
- Adds decoded-frame integration tests for visibility combinations.
- Adds RGB inspection helpers, packaged FFmpeg lookup, and test instructions.
| File | Description |
|---|---|
| tests/osn-tests/util/README.md | Documents selective-recording tests and helpers. |
| tests/osn-tests/util/media_probe.ts | Adds RGB decoding and packaged FFmpeg lookup. |
| tests/osn-tests/util/media_assertions.ts | Adds region-color assertions. |
| tests/osn-tests/src/test_osn_selective_recording.ts | Tests Simple and Advanced recording visibility. |
| obs-studio-server/source/osn-simple-recording.cpp | Selects the recording render mix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sandboxcoder
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Simple recording’s HighQuality and HigherQuality presets to use OBS_RECORDING_VIDEO_RENDERING when selective recording is enabled. Previously, they selected OBS_STREAMING_VIDEO_RENDERING, causing recordings to follow stream visibility instead of recording visibility.
Add integration tests that inspect decoded recording frames for all four stream/recording visibility combinations. Cover both Simple presets with selective recording enabled and disabled, plus Advanced recording with a dedicated encoder.
Add an RGB frame decoding helper, packaged FFmpeg lookup, and instructions for running the focused suite.
Motivation and Context
Sources excluded from recording could appear in saved videos, while sources visible only in recordings could disappear. This occurred during ordinary recording without starting streaming or a replay buffer.
The regression tests verify saved video content, including a background control that rejects empty or black recordings.
How Has This Been Tested?
Integration tests, manual tests. Windows only.
Types of changes