Skip to content

feat(map): circle-crop opaque honeymoon pin images #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
streambinder merged 1 commit into from
Sep 29, 2026
Merged

feat(map): circle-crop opaque honeymoon pin images #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions static/css/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4696,6 +4696,15 @@ td [role="switch"] {
contrast(1.08) brightness(0.88) drop-shadow(0 12px 24px rgb(42 52 57 / 18%));
}

/* Opaque images (no alpha, e.g. JPG): circle-crop via CSS instead of
showing a rigid squared box. Transparent images keep their shape. */
.places-pin-media-opaque img {
width: 88%;
height: 88%;
object-fit: cover;
border-radius: 50%;
}

.places-pin-media-placeholder {
display: flex;
align-items: center;
Expand Down
4 changes: 3 additions & 1 deletion static/places.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,9 +422,11 @@

function renderHoneymoonPin(place) {
const title = escapeHtml(place.label || place.name || "Stop");
// Transparent images keep their natural shape; opaque ones (e.g. JPG)
// are circle-cropped so they never render as a rigid squared box.
const transparentClass = supportsTransparency(place.image)
? " places-pin-media-transparent"
: "";
: " places-pin-media-opaque";
return place.image
? '<div class="places-pin-media' +
transparentClass +
Expand Down
Loading