Skip to content

add stable_hashrate flag to channels_sv2::server#2152

Open
plebhash wants to merge 1 commit into
stratum-mining:mainfrom
plebhash:2026-05-12-stable-hashrate-bool
Open

add stable_hashrate flag to channels_sv2::server#2152
plebhash wants to merge 1 commit into
stratum-mining:mainfrom
plebhash:2026-05-12-stable-hashrate-bool

Conversation

@plebhash
Copy link
Copy Markdown
Member

@plebhash plebhash commented May 12, 2026

@plebhash plebhash force-pushed the 2026-05-12-stable-hashrate-bool branch from 793b918 to 782ef9a Compare May 12, 2026 21:00
@plebhash plebhash changed the title add stable_hashrate flag to channels_sv2 add stable_hashrate flag to channels_sv2::server May 12, 2026
@plebhash plebhash force-pushed the 2026-05-12-stable-hashrate-bool branch from 782ef9a to 9edcc5f Compare May 12, 2026 21:41
@plebhash plebhash marked this pull request as ready for review May 12, 2026 21:51
Copy link
Copy Markdown
Member

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed we need to add the new stable_hashrate field in the channels docs.

/// - the channel's requested max target (limit established by the client)
/// - the channel's current target
/// - the channel's mapping between `job_id` and target
/// - the channel's nominal hashrate
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the new stable_hashrate here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks

fixed

/// - the channel's requested max target (limit established by the client)
/// - the channel's current target
/// - the channel's mapping between `job_id` and target
/// - the channel's nominal hashrate
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the new stable_hashrate here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks

fixed

@plebhash plebhash force-pushed the 2026-05-12-stable-hashrate-bool branch from 9edcc5f to b703546 Compare May 13, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

channels_sv2::server should expose whether vardiff has converged (via stable_hashrate: bool statevar)

2 participants