Reduce time complexity of type checking ops in Factory, prove termination of LExpr.resolveAux #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of LExpr.resolveAux This patch - Avoids recursive traversal of body of LFuncs in Factory during type checking. Instead, the bodys are typechecked separately. - Proves termination of LExpr.resolveAux. The above refactoring enabled this :) - And adds tiny well-formedness statements about type variables of LFunc.
aqjune-aws
force-pushed
the
jlee/typechk
branch
from
6e68d0f to
23879ce
Compare
aqjune-aws
changed the title
joscoh
reviewed
Feb 6, 2026
Contributor
|
I simplified a few of the |
Contributor
Author
|
Thanks, I should learn how to find appropriate Decidable instances too. :) |
joscoh
previously approved these changes
Feb 6, 2026
joscoh
approved these changes
Feb 9, 2026
MikaelMayer
reviewed
Feb 9, 2026
MikaelMayer
reviewed
Feb 9, 2026
andrewmwells-amazon
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch
FactoryWFbecause it was getting larger.The
axiomsclause is not removed yet in this pull request, since it seems to require quite a few updates to translation of Map related functions.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.