Skip to content

chore(work): drop unused loop-export complete notification - #199

Draft
stozo04 wants to merge 1 commit into
mainfrom
cursor/drop-unused-complete-notification-a7e9
Draft

stozo04 wants to merge 1 commit into
mainfrom
cursor/drop-unused-complete-notification-a7e9

Conversation

@stozo04

@stozo04 stozo04 commented Sep 18, 2026

Copy link
Copy Markdown
Owner

Description

Remove dead loop-export "complete" notification surface that has zero callers in production or test code.

What was removed:

  • BoomerangRenderNotifications.buildCompleteNotification() function (lines 63–81)
  • BoomerangRenderNotificationsRobolectricTest.buildCompleteNotification_usesImmutablePendingIntent() test
  • notification_loop_export_complete_title string resource
  • notification_loop_export_complete_text string resource

What remains (actively used):

  • buildProgressNotification — used by the worker during render
  • createForegroundInfo — the foreground service entry point
  • Channel setup and FGS type gating — all live

Verified via grep: no remaining references to buildCompleteNotification or the deleted string resources exist in the codebase.

Related Issue

N/A — routine cleanup of unreachable code

Type of Change

  • 🔧 Chore: Build configuration changes, dependency updates, or toolchain adjustments

How Has This Been Tested?

  • Static Verification: Confirmed zero callers via grep across entire codebase (including tests and all locales)
  • Automated Tests: CI will verify build + existing tests pass with the deletions

Checklist

  • 🧪 My changes have been verified locally and work as expected.
  • 🔍 I have performed a self-review of my own code.
  • ✍️ I have commented my code, particularly in hard-to-understand areas. (N/A — deletions only)
  • 📖 My changes generate no compile warnings or errors (allWarningsAsErrors is on). (CI will verify)
  • 🧹 Pre-PR sweep GREEN on the final commit — Android SDK not available in cloud environment; CI will verify full build
  • 🏪 Play-facing docs aligned: N/A — no user-facing changes
  • 🧹 The git branch is clean and references to obsolete branches have been pruned.
Open in Web Open in Cursor 

Remove buildCompleteNotification function, its test, and two unused string resources
that had zero callers in production or test code. Worker only uses buildProgressNotification
and createForegroundInfo.

Deleted:
- BoomerangRenderNotifications.buildCompleteNotification()
- BoomerangRenderNotificationsRobolectricTest.buildCompleteNotification_usesImmutablePendingIntent()
- notification_loop_export_complete_title string resource
- notification_loop_export_complete_text string resource

No behavior change.

Co-authored-by: Steven Gates <gates.steven@gmail.com>

@stozo04 stozo04 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right for tonight's cleanup. dead buildCompleteNotification + unused complete strings + the orphaned robolectric test for it — net -31, progress/FGS path untouched. no behavior change. ready when you are — still draft.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants