Skip to content

Add password protected Linksharing design - #28

Open
wilfred-asomanii wants to merge 1 commit into
mainfrom
wilfred/password-protected-linksharing
Open

Add password protected Linksharing design#28
wilfred-asomanii wants to merge 1 commit into
mainfrom
wilfred/password-protected-linksharing

Conversation

@wilfred-asomanii

Copy link
Copy Markdown
Contributor


- **CAPTCHA layer.** With the inclusion of per-accessKeyID and/IP rate limiting, we mitigate the risk factor of brute force
attacks, but do we also want to include captcha requirements on password submissions?
- **Paid-tier gating.** Do we want this feature to be available to paid-users and others with paid privileges?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes only for paid tier.

- **CAPTCHA layer.** With the inclusion of per-accessKeyID and/IP rate limiting, we mitigate the risk factor of brute force
attacks, but do we also want to include captcha requirements on password submissions?
- **Paid-tier gating.** Do we want this feature to be available to paid-users and others with paid privileges?
- **Raw downloads.** Do we want password protected shares to be downloadable?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that would be a bug.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have been clearer here 😅
I mean after the user has unlocked by password for the first time.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) yes after password is entered then we can show the linksharing page as usual with download enabled.

attacks, but do we also want to include captcha requirements on password submissions?
- **Paid-tier gating.** Do we want this feature to be available to paid-users and others with paid privileges?
- **Raw downloads.** Do we want password protected shares to be downloadable?
- **Previews.** Do we want to support social previews to work for these shares?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that would be privacy leak.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the previous comment,
I mean after the user has unlocked by password for the first time.
This is more a technical decision whether we want to block previews and downloads entirely whether the user has unlocked the link share

### Open questions

- **CAPTCHA layer.** With the inclusion of per-accessKeyID and/IP rate limiting, we mitigate the risk factor of brute force
attacks, but do we also want to include captcha requirements on password submissions?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be good yes.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the rate limiter would consider both the accessKeyID and IP address at the same time, because if we rate-limit only by accessKeyID, we might unintentionally block access for the n+1 user. Anyway, I don’t think we would even need this rate limiter if we implement captcha, right?

@boshevski

Copy link
Copy Markdown

Thank you Wilfred, I added some comments on the open questions.

@amwolff amwolff left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants