Merge crybapy2 to the main branch - #39
Merged
Merged
Conversation
Remove or fix linter settings that are no longer accepted by the golangci-lint v1.61 config schema, which caused CI to fail on config verification: - Remove govet.use-installed-packages - Remove goimports settings block - Remove golint settings block (linter was removed from golangci-lint) - Fix misspell bare null value to empty object - Remove unused.check-exported - Remove unparam settings block - Fix receiver naming lint error
To determine the correct error code for transient node errors, log the RPC error code and message whenever SendTransaction fails. Non-RPC errors (e.g. network errors) are also logged for completeness. Once we know the actual error code returned by the node, we will use it to implement a proper retry mechanism for transient failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already use the crybapy2 branch for SNO payouts, so it deserves to be merged to the main branch.