This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Open
Conversation
This adds a new build stage in the CI where the container image is built once and pushed to docker hub. The test and deploy stages pull the same image and use it. New docker hub repo: https://hub.docker.com/r/stosci/cluster-operator
197cbe4 to
dc4b5d3
Compare
croomes
approved these changes
Sep 6, 2019
Contributor
croomes
left a comment
There was a problem hiding this comment.
LGTM once the pipline passes
Contributor
Author
|
TravisCI env vars are not shared with pull requests from forks. The same is true for the encrypted variables https://docs.travis-ci.com/user/environment-variables/#defining-encrypted-variables-in-travisyml . We may not be able to make this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new build stage in the CI where the container image is built
once and pushed to docker hub. The test and deploy stages pull the same
image and use it.
New docker hub repo:
https://hub.docker.com/r/stosci/cluster-operator