feat: show file size limits where applicable#884
feat: show file size limits where applicable#884amycatgirl wants to merge 1 commit intostoatchat:mainfrom
Conversation
|
Can we update this to pull the limits from the configuration? stoatchat/stoatchat#644 will expose that information, and stoatchat/javascript-client-sdk#127 loads the configuration. |
|
Sure! I would be glad to do so once both PRs are merged. |
|
Seems like both PRs were merged, so I'll work on integrating that work into my branch hopefully i don't get caught in conflict resolution hell again |
amycatgirl
force-pushed
the
feat/show-file-size-limits
branch
from
50b6f0f to
509391d
Compare
|
hmm, i see that there isn't a type for the newly added which means that the typescript linter/compiler will absolutely yell at me for trying to use it should I make a PR to add said types? |
|
also the ci bot ruined my branch again!! |
|
I'd love to see that!
…On Thu, Mar 19, 2026 at 12:35 PM Amy ***@***.***> wrote:
*amycatgirl* left a comment (stoatchat/for-web#884)
<#884 (comment)>
hmm, i see that there isn't a type for the newly added limits field in
the instance's configuration.
which means that the typescript linter/compiler will absolutely yell at me
for trying to use it
should I make a PR to add said types?
—
Reply to this email directly, view it on GitHub
<#884?email_source=notifications&email_token=AAESJGLDAQT5TKURZE2DHUL4RQ4YLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMBZGI2DENRYGA3KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4092426806>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAESJGPFDLQYUKH224LLBYD4RQ4YLAVCNFSM6AAAAACV4ERR3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAOJSGQZDMOBQGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
ah, it seems that the API types are autogenerated, and according to the latest commit, it does include the im not sure if i have to point the client sdk to the latest commit though |
Signed-off-by: Amy <amy+git@amogus.cloud>
amycatgirl
force-pushed
the
feat/show-file-size-limits
branch
from
9bd5f34 to
aebb390
Compare
chrishultin
left a comment
chrishultin
left a comment
There was a problem hiding this comment.
This appears to still have hardcoded size limits - I thought the intent was to pull those dynamically?
|
yes, i was waiting on the js sdk submodule getting bumped because otherwise typescript complains about the all i did was pull in changes from main |
more specifically, the stoat-api package inside of the sdk, as that contains the types generated from the OpenAPI schema |
2 participants
Should clear up some confusion about what the file size limits are across the app. Obviously, the app needs a way to get this from the backend (ideally via the root endpoint), but for now this shall suffice.