Migrate CMake deps to FetchContent and more std:: usage#84
Migrate CMake deps to FetchContent and more std:: usage#84ilelann wants to merge 1 commit intostlab:mainfrom
Conversation
getting rid of setup_dep CMake helper also contains some s/std/boost/ to remove few boost submodules std::thread std::tuple std::chrono std::bind (but boost::bind is still required indirectly) at last, some minor fixes to compile without warning
| #include <vector> | ||
|
|
||
| #ifdef ADOBE_BUILT_WITH_CMAKE | ||
| #include <double-conversion/double-conversion.h> |
There was a problem hiding this comment.
not sure how non-CMake build setups will react to that :)
camio
left a comment
camio
left a comment
There was a problem hiding this comment.
Could you please break this PR into multiple PRs? As it stands it is too big to reasonably review. For example, the migration of CMake deps to FetchContent is stand alone. As is each of the migrations to std from boost.
| build_asl/ | ||
|
|
||
| # CLion | ||
| cmake-build-*/ |
There was a problem hiding this comment.
IDE and editor-specific files should be added to global .gitignore files instead of project ones. See this stack overflow article.
Agreed. I will split the PR. |
2 participants
getting rid of setup_dep CMake helper
also contains some s/std/boost/ to remove few boost submodules
std::thread
std::tuple
std::chrono
std::bind (but boost::bind is still required indirectly)
at last, some minor fixes to compile without warning