Fix undefined behavior in string_pool memory management#150
Merged
sean-parent merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
The string_pool_t destructor was using delete on memory allocated with ::operator new, which is undefined behavior. Memory allocated with ::operator new must be deallocated with ::operator delete. Changes: - Replace adobe::for_each(pool_m, adobe::delete_ptr()) with explicit loop using ::operator delete - Remove unused includes: adobe/algorithm/for_each.hpp and adobe/functional.hpp Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed undefined behavior in
string_pool_tdestructor where memory allocated with::operator newwas being deallocated withdeleteinstead of::operator delete.Details
In
source/string_pool.cpp:::operator new(pool_size)for raw memory poolsadobe::for_each(pool_m, adobe::delete_ptr())which callsdeleteThe fix:
::operator deleteadobe/algorithm/for_each.hppandadobe/functional.hpp)Impact
This fixes a potential memory corruption issue. While the code may have appeared to work in practice, using
deleteon memory from::operator newis undefined behavior and could cause issues with certain allocators or debugging tools.🤖 Generated with Claude Code