Skip to content

(closes #2642) Support structure type extends and contains - #3563

Open
sergisiso wants to merge 13 commits into
masterfrom
2642_extend_structure_type
Open

(closes #2642) Support structure type extends and contains#3563
sergisiso wants to merge 13 commits into
masterfrom
2642_extend_structure_type

Conversation

@sergisiso

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (72527a7) to head (83e6657).

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #3563    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          397       397            
  Lines        55775     56023   +248     
==========================================
+ Hits         55775     56023   +248     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso sergisiso self-assigned this Aug 20, 2026
@sergisiso
sergisiso deployed to integration August 20, 2026 15:15 — with GitHub Actions Active
@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter @LonelyCat124 This is ready to review, it is a necesarry step to read the metadata using psyir. Wihtout this the embedded metadata ends up in an UnsupportedFortranType, and we still would need to parse it as a string.

It seems that Rupert started this path of parsing the metadata from the UnsupportedType as a string, at the moment I convert the new datatype back to an string and then pass it to existing metadata parsing to keep coverage of the existing tests (which feels odd). The previous PR adding this this feature #2644 also hit the same problem.

However, I have a follow up PR that converts the metadata parsing to take proper PSyIR (removing the need of fparser1 and string metadata parsing) and the code that lose coverage can be removed altoghether. But the resulting PR was huge. In fact I cut this branch to make the whole review more manegable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant