Skip to content

(Closes #3506) added fparser ref detection to util script + cleanup - #3561

Merged
sergisiso merged 11 commits into
masterfrom
3506_fparser_cleanup
Aug 21, 2026
Merged

(Closes #3506) added fparser ref detection to util script + cleanup#3561
sergisiso merged 11 commits into
masterfrom
3506_fparser_cleanup

Conversation

@haanahfrost

@haanahfrost haanahfrost commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

This PR extends the manual reference checker in the utils folder check_closed_issue_refs.py (follow up from #3556) to catch references to closed issues in the fparser directory.
Now after running the audit these are the final issues which need cleaning up:

Needs removal:

Needs changes:

  • character strings include quotes fparser#295 (fparser2) flags on the audit due to the comment format being:
    # fparser2 (issue #295) so the regex does not catch this as an fparser issue. Instead of changing the regex (which would be risky and may lead to false positives), would it be better to change the comment format to #TODO fparser #295 and standardise these practices when adding todos in the future?

Accepted formats:

  • fparser #295
  • fparser#295
  • fparser/#295
  • fparser issue #295

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c17997a) to head (8fc1b74).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3561   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines        55775     55775           
=========================================
  Hits         55775     55775           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso sergisiso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haanahfrost for addressing the last reported issues:

  • I agree with the fix to 111.

  • The remaining 753 should be replaced with 1618

  • For fparser 174, 295 and 469, I would prefer if you restored the previous version of utils/check_closed_issue_refs.py and instead replaced the references to fparser issues with full urls. For example instead of fparser #295, use https://github.com/stfc/fparser/issues/295

@haanahfrost
haanahfrost marked this pull request as ready for review August 20, 2026 10:23

@sergisiso sergisiso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks @haanahfrost

@sergisiso
sergisiso merged commit 72527a7 into master Aug 21, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants