Admin calendar: Avoid duplicate database query#522
Open
zosterops-lateralis wants to merge 1 commit into
Open
Conversation
The constructor for `WP_Query` already calls its `get_posts()` method. There is no need to call it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
It seems that the
eventorganiser_admin_calendar()function (which handles theevent-admin-calAjax action) always performs the same database query twice.In fact, the constructor for
WP_Querycalls thequery()method, which itself already calls theget_posts()method. Therefore, calling$query->get_posts()after contructing the$queryobject is unnecessary, as all the posts are already available in the$queryobject, and it will needlessly repeat the previous database query.This PR simply proposes to remove the call to
$query->get_posts().Thanks!
Zosterops