Support custom design library locations - #1209
Merged
Merged
Conversation
Contributor
|
🎉 Zip build complete |
rahulacaleffi
marked this pull request as draft
August 4, 2026 00:18
rahulacaleffi
marked this pull request as ready for review
August 4, 2026 13:19
bordoni
approved these changes
Aug 5, 2026
Contributor
Author
|
@bordoni , requesting your review again since a couple changes have been pushed. Thanks in advance.
|
bordoni
approved these changes
Aug 5, 2026
gilbert-hernandez
approved these changes
Aug 5, 2026
gilbert-hernandez
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I remember hoping that the allowlist was correct in 3.7.8.1.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎫 SMTNC-1912
The library hardening in 3.7.8.1 only accounted for the Kadence hosts and for libraries saved through Cloud Connect. Design libraries registered in PHP with the existing
kadence_blocks_custom_prebuilt_librariesfilter were left out, so their tab still opened in the editor but nothing inside it loaded: categories, patterns and previews all came back asInvalid Request, Unknown Library.This PR widens the list of locations the editor can request. It brings
kadence_blocks_custom_prebuilt_librariesback into play and adds a newkadence_blocks_allowed_library_urlsfilter for adding or removing locations, while keeping the list built server-side so it stays under the site owner's control. A site owner can also drop URLs straight into the array in the plugin, if necessary, even though the filter is the one always recommended.Detailed breakdown:
API_Url_Trait::get_allowed_library_urls()merges the Kadence hosts, saved Cloud Connect connections and libraries registered in PHP, and has a commented spot for a site owner to add their own.kadence_blocks_allowed_library_urlsfilter for adding or removing a location without editing the plugin.manage options.Checklist