update the SAC interface to include CAP-73's trust function#2454
Open
ElliotFriend wants to merge 1 commit into
Open
update the SAC interface to include CAP-73's trust function#2454ElliotFriend wants to merge 1 commit into
trust function#2454ElliotFriend wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Documents CAP-73’s new trust function on the Stellar Asset Contract (SAC) interface so developers can discover and understand the trustline-creation behavior from the tokens documentation.
Changes:
- Added
trust(env: Env, addr: Address)to the documentedStellarAssetInterfacetrait. - Documented
trustsemantics (no-op cases, authorization requirement, panic conditions).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// provided G-address already has the respective trustline. | ||
| /// | ||
| /// If the trustline is actually created, this will require authorization | ||
| /// from `addr` (i.e. `addr.require_auth` will be called). |
Comment on lines
+215
to
+216
| /// Panics during trustline creation if the asset issuer does not exist, | ||
| /// or when a new trustline cannot be created. |
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAP-73 includes the new trustline creation function on the SAC interface. Documenting that function in the tokens section here.