Bump XDR to latest Protocol 26#944
Merged
Merged
Conversation
|
Size Change: +9.7 kB (+0.27%) Total Size: 3.54 MB
|
There was a problem hiding this comment.
Pull request overview
Updates the repository’s “curr” and “next” Stellar XDR snapshots and regenerated JS/TS bindings to align with the latest Protocol 26 definitions.
Changes:
- Adds new transaction / operation result codes related to frozen trustlines and frozen ledger-key access.
- Expands Soroban-related config/settings XDR (frozen ledger keys + bypass tx hashes) and adds new Soroban cost types (BN254).
- Regenerates
src/generated/*andtypes/*.d.tsfrom the updated XDR, and bumps upstream XDR base SHAs inMakefile.
Reviewed changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| xdr/next/Stellar-transaction.x | Adds new result codes for trustline-frozen and frozen-key-accessed cases. |
| xdr/next/Stellar-contract-spec.x | Removes several array upper-bounds in Soroban contract spec structures. |
| xdr/next/Stellar-contract-config-setting.x | Adds EncodedLedgerKey + frozen ledger key/bypass-tx settings and BN254 cost types. |
| xdr/next/Stellar-SCP.x | Updates comment describing SCPQuorumSet nesting. |
| xdr/curr/Stellar-transaction.x | Mirrors the new result codes in the “curr” snapshot. |
| xdr/curr/Stellar-contract-spec.x | Mirrors contract spec bound removals in the “curr” snapshot. |
| xdr/curr/Stellar-contract-config-setting.x | Mirrors new config settings + BN254 cost types in the “curr” snapshot. |
| xdr/curr/Stellar-SCP.x | Mirrors the SCPQuorumSet comment update in the “curr” snapshot. |
| types/next.d.ts | Regenerated TS declarations reflecting new XDR types/cases/settings. |
| types/curr.d.ts | Regenerated TS declarations reflecting new XDR types/cases/settings. |
| src/generated/next_generated.js | Regenerated JS XDR bindings for “next”. |
| src/generated/curr_generated.js | Regenerated JS XDR bindings for “curr”. |
| Makefile | Updates upstream stellar-xdr base URLs (commit SHAs) used for fetching XDR. |
Comments suppressed due to low confidence (2)
xdr/next/Stellar-SCP.x:85
- The comment says SCPQuorumSet "only allows 4 levels of nesting", but the XDR definition has
innerSets<>with no max length/depth constraint, so the statement is misleading. Consider rewording to avoid implying an enforced limit (e.g., describe typical usage or remove the numeric limit).
// supports things like: A,B,(C,D,E),(F,G,(H,I,(J,K,(L,M))))
// only allows 4 levels of nesting
struct SCPQuorumSet
{
uint32 threshold;
NodeID validators<>;
SCPQuorumSet innerSets<>;
};
xdr/curr/Stellar-SCP.x:85
- The comment says SCPQuorumSet "only allows 4 levels of nesting", but the XDR definition has
innerSets<>with no max length/depth constraint, so the statement is misleading. Consider rewording to avoid implying an enforced limit (e.g., describe typical usage or remove the numeric limit).
// supports things like: A,B,(C,D,E),(F,G,(H,I,(J,K,(L,M))))
// only allows 4 levels of nesting
struct SCPQuorumSet
{
uint32 threshold;
NodeID validators<>;
SCPQuorumSet innerSets<>;
};
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+290
to
+296
| // // Cost of performing BN254 scalar element addition/subtraction | ||
| Bn254FrAddSub = 81, | ||
| // Cost of performing BN254 scalar element multiplication | ||
| Bn254FrMul = 82, | ||
| // Cost of performing BN254 scalar element exponentiation | ||
| Bn254FrPow = 83, | ||
| // Cost of performing BN254 scalar element inversion |
Comment on lines
+290
to
+296
| // // Cost of performing BN254 scalar element addition/subtraction | ||
| Bn254FrAddSub = 81, | ||
| // Cost of performing BN254 scalar element multiplication | ||
| Bn254FrMul = 82, | ||
| // Cost of performing BN254 scalar element exponentiation | ||
| Bn254FrPow = 83, | ||
| // Cost of performing BN254 scalar element inversion |
Ryang-21
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.