Skip to content

Bump XDR to latest Protocol 26#944

Merged
Ryang-21 merged 1 commit into
masterfrom
protocol-next
Mar 24, 2026
Merged

Bump XDR to latest Protocol 26#944
Ryang-21 merged 1 commit into
masterfrom
protocol-next

Conversation

@Shaptic
Copy link
Copy Markdown
Contributor

@Shaptic Shaptic commented Mar 18, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 18, 2026 20:51
@github-actions
Copy link
Copy Markdown

Size Change: +9.7 kB (+0.27%)

Total Size: 3.54 MB

Filename Size Change
dist/stellar-base.js 2.62 MB +7.47 kB (+0.29%)
dist/stellar-base.min.js 924 kB +2.23 kB (+0.24%)

compressed-size-action

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s “curr” and “next” Stellar XDR snapshots and regenerated JS/TS bindings to align with the latest Protocol 26 definitions.

Changes:

  • Adds new transaction / operation result codes related to frozen trustlines and frozen ledger-key access.
  • Expands Soroban-related config/settings XDR (frozen ledger keys + bypass tx hashes) and adds new Soroban cost types (BN254).
  • Regenerates src/generated/* and types/*.d.ts from the updated XDR, and bumps upstream XDR base SHAs in Makefile.

Reviewed changes

Copilot reviewed 9 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
xdr/next/Stellar-transaction.x Adds new result codes for trustline-frozen and frozen-key-accessed cases.
xdr/next/Stellar-contract-spec.x Removes several array upper-bounds in Soroban contract spec structures.
xdr/next/Stellar-contract-config-setting.x Adds EncodedLedgerKey + frozen ledger key/bypass-tx settings and BN254 cost types.
xdr/next/Stellar-SCP.x Updates comment describing SCPQuorumSet nesting.
xdr/curr/Stellar-transaction.x Mirrors the new result codes in the “curr” snapshot.
xdr/curr/Stellar-contract-spec.x Mirrors contract spec bound removals in the “curr” snapshot.
xdr/curr/Stellar-contract-config-setting.x Mirrors new config settings + BN254 cost types in the “curr” snapshot.
xdr/curr/Stellar-SCP.x Mirrors the SCPQuorumSet comment update in the “curr” snapshot.
types/next.d.ts Regenerated TS declarations reflecting new XDR types/cases/settings.
types/curr.d.ts Regenerated TS declarations reflecting new XDR types/cases/settings.
src/generated/next_generated.js Regenerated JS XDR bindings for “next”.
src/generated/curr_generated.js Regenerated JS XDR bindings for “curr”.
Makefile Updates upstream stellar-xdr base URLs (commit SHAs) used for fetching XDR.
Comments suppressed due to low confidence (2)

xdr/next/Stellar-SCP.x:85

  • The comment says SCPQuorumSet "only allows 4 levels of nesting", but the XDR definition has innerSets<> with no max length/depth constraint, so the statement is misleading. Consider rewording to avoid implying an enforced limit (e.g., describe typical usage or remove the numeric limit).
// supports things like: A,B,(C,D,E),(F,G,(H,I,(J,K,(L,M))))
// only allows 4 levels of nesting
struct SCPQuorumSet
{
    uint32 threshold;
    NodeID validators<>;
    SCPQuorumSet innerSets<>;
};

xdr/curr/Stellar-SCP.x:85

  • The comment says SCPQuorumSet "only allows 4 levels of nesting", but the XDR definition has innerSets<> with no max length/depth constraint, so the statement is misleading. Consider rewording to avoid implying an enforced limit (e.g., describe typical usage or remove the numeric limit).
// supports things like: A,B,(C,D,E),(F,G,(H,I,(J,K,(L,M))))
// only allows 4 levels of nesting
struct SCPQuorumSet
{
    uint32 threshold;
    NodeID validators<>;
    SCPQuorumSet innerSets<>;
};

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +290 to +296
// // Cost of performing BN254 scalar element addition/subtraction
Bn254FrAddSub = 81,
// Cost of performing BN254 scalar element multiplication
Bn254FrMul = 82,
// Cost of performing BN254 scalar element exponentiation
Bn254FrPow = 83,
// Cost of performing BN254 scalar element inversion
Comment on lines +290 to +296
// // Cost of performing BN254 scalar element addition/subtraction
Bn254FrAddSub = 81,
// Cost of performing BN254 scalar element multiplication
Bn254FrMul = 82,
// Cost of performing BN254 scalar element exponentiation
Bn254FrPow = 83,
// Cost of performing BN254 scalar element inversion
@Ryang-21 Ryang-21 merged commit 4830b73 into master Mar 24, 2026
12 checks passed
@Ryang-21 Ryang-21 deleted the protocol-next branch March 24, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants