Add tests for cache-keys helpers and refactor parameters for easier testing#163
Open
coding-creed-technologies wants to merge 1 commit intosteipete:mainfrom
Open
Conversation
…ility Add unit tests for helper functions in `cache-keys.ts`. While adding tests, some functions were updated to use named arguments instead of destructured parameters to simplify test setup and make inputs easier to construct in isolation. Tests cover: - string and JSON hashing helpers - prompt instruction and content hashing - tagged block extraction - content normalization - cache key generation helpers for extract, summary, slides, and transcript The parameter changes are purely structural and do not alter the resulting cache keys or runtime behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds unit tests for cache key helper functions and introduces a small refactor to make some functions easier to test.
Several functions in
cache-keys.tswere updated to use named parameters instead of destructured objects. This simplifies test setup and makes it easier to construct inputs when testing cache key generation logic.Changes
cache-keys.tshashString,hashJson)Test Isolation
The tests focus on validating deterministic behavior of the cache key helpers.
Inputs are constructed directly to ensure hashing and normalization logic behaves consistently across environments.
Notes
The parameter adjustments were introduced only to simplify testing and do not change the resulting cache keys or runtime behavior.
Impact
Improves test coverage for cache key generation logic and helps ensure consistent hashing behavior for prompts, content, and caching metadata.
Attribution
This contribution was generated with assistance from 3TG.
3TG is a behavior-first test generation tool for TypeScript functions that creates clean, maintainable tests and improves developer productivity.