calendar: avoid ambiguous timezone inference from offsets#492
Open
RaphaelRUzan wants to merge 1 commit intosteipete:mainfrom
Open
calendar: avoid ambiguous timezone inference from offsets#492RaphaelRUzan wants to merge 1 commit intosteipete:mainfrom
RaphaelRUzan wants to merge 1 commit intosteipete:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid ambiguous regional timezone inference from offset-only RFC3339 inputs.
This changes calendar event timezone extraction to use fixed-offset
Etc/GMT±Nzones instead of guessing named regions likeAmerica/PhoenixorAmerica/Los_Angelesfrom a numeric offset alone.Why
Offsets like
-07:00are ambiguous at a given instant and can match multiple regional IANA zones. The previous logic returned the first matching US timezone, which could mislabel Pacific events asAmerica/Phoenix.Using a fixed-offset timezone is less pretty, but safer and non-deceptive when the input does not carry a true named timezone.
Changes
extractTimezone()UTCfor zero offsetEtc/GMT±Nfallback for whole-hour offsetsTests
Ran:
Related