chore(ci): fix effect bump workflow and track the rc line - #195
Merged
Conversation
The Effect Beta Bump workflow failed on every run since it was added: the bump rewrites the catalog pin, and CI defaults pnpm to --frozen-lockfile, which rejects the now-stale lockfile with ERR_PNPM_LOCKFILE_CONFIG_MISMATCH before validation ever runs. Refresh the lockfile with --no-frozen-lockfile. Effect 4 has also moved from the `beta` dist-tag (frozen at beta.107) to `rc`. The script now reads both tags, picks the highest 4.0.0-<beta|rc>.N, and also rewrites the `effect@<tag>` install token in the docs so the documented install never lands below the tested floor. Skill and doc prose updated to say "prerelease line". Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ABKLh91QnvkCdKW3KHjXhy
|
🎉 This PR is included in version 0.31.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Effect Beta Bump workflow has failed on all 51 runs since it was added (Jul 18). The bump step rewrites the catalog pin in
pnpm-workspace.yaml, thenvp installruns under CI's default--frozen-lockfileand refuses the intentionally stale lockfile:Every downstream step was skipped, so no bump PR was ever opened.
Meanwhile Effect 4 moved from the
betadist-tag (frozen at4.0.0-beta.107) torc(4.0.0-rc.112today). The script only readbetaand would never have followed.What
vp install --no-frozen-lockfilefor the lockfile refresh step.scripts/bump-effect-beta.mjs: readsrc+betadist-tags, picks the highest4.0.0-<beta|rc>.N(numbers are shared across lines), and also rewrites theeffect@<tag>install token in the five docs so the documented install command never lands below the tested floor. Still refuses stable4.0.0./effect-betaskill + doc caveat lines: "beta line" → "prerelease line". Script, workflow, and skill keep theirbetanames.Verified locally:
--dry-runtargetsbeta.98 → rc.112; a real run rewrites all nine files includingeffect@beta → effect@rc(reverted, not part of this PR).Validation
vp run check: passvp run test: 54 files / 795 tests passvp run test:types: 16 files / 149 tests passAfter merge
Dispatch the workflow (or wait for the 06:00 UTC cron). Expect a draft PR: the floor is 14 prereleases behind, so validation against rc.112 will likely surface upstream breaking changes to migrate.
🤖 Generated with Claude Code
https://claude.ai/code/session_01ABKLh91QnvkCdKW3KHjXhy