Warn when NSRL Bloom filter actual count exceeds estimate#164
Merged
steffenfritz merged 1 commit intomainfrom Apr 7, 2026
Merged
Warn when NSRL Bloom filter actual count exceeds estimate#164steffenfritz merged 1 commit intomainfrom
steffenfritz merged 1 commit intomainfrom
Conversation
Print stats (estimated, actual, target FPR) after building the filter, and emit a warning with the recommended --nsrl-estimate value when the actual item count exceeds the estimate — the primary cause of elevated false positive rates. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
Fixed filewalk_test.go. Missing "testdata/noaccess.rtf" and "testdata/testpipe" added to want lists. |
Owner
Author
|
PASS |
Owner
Author
|
steffen@ceres ~/g/s/g/s/F/c/admftrove (pr-164)> ./admftrove_arm64_darwin_static --creatensrl nsrlinputtest.txt |
Owner
Author
|
I fed a text file with four lines as an input to admftrove to create a nsrl.bloom file. The file size is 91 MB. There is a short header, and then approx. 90.9MB (padded?) zeros. This is a strange behaviour and I think bloom is not working as expected. -> Issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateNSRLBloomcompletesWARNINGwith the recommended--nsrl-estimatevalue when actual item count exceeds the estimateTest plan
admftroveand run--create-nsrlwith a hash file larger than the estimate — verify warning is printed🤖 Generated with Claude Code