Skip to content

fix: validate assignment target in JsonPointer.set() #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefankoegl merged 3 commits into from
Oct 2, 2026
Merged

fix: validate assignment target in JsonPointer.set() #80

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7478f3e
fix: validate assignment target in JsonPointer.set()
abhi-0203 Sep 19, 2026
c7e5a97
Fix string detection in JsonPointer.set()
stefankoegl Oct 1, 2026
a6adb1f
Potential fix for pull request finding 'Fix dedentation causing Inden…
stefankoegl Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions jsonpointer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,15 @@ def set(self, doc, value, inplace=True):

(parent, part) = self.to_last(doc)

if isinstance(parent, Sequence) and part == '-':
if isinstance(parent, str):
raise JsonPointerException("Cannot set value in a string")
elif isinstance(parent, Sequence) and part == '-':
parent.append(value)
else:
parent[part] = value
try:
parent[part] = value
except (TypeError, IndexError) as e:
raise JsonPointerException("Invalid assignment target: %s" % (e,))
Comment on lines +217 to +220

return doc

Expand Down
Loading