Skip to content

Fix typo in RelationAnalysis:functions_changed #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sipma merged 1 commit into from
Mar 20, 2026
Merged

Fix typo in RelationAnalysis:functions_changed #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions chb/relational/RelationalAnalysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,14 +210,14 @@ def functions_changed(self) -> List[str]:
result.append(faddr)

for (faddr1, md51) in self.md5s1.items():
if faddr in self.md5s2:
if (md51 == self.md5s2[faddr1]) or (faddr in result):
if faddr1 in self.md5s2:
if (md51 == self.md5s2[faddr1]) or (faddr1 in result):
continue
else:
chklogger.logger.warning(
"Function not analyzed changed: %s. "
+ "Original md5: %s; Patched md5: %s",
faddr1, md51, self.md5s2[faddr])
faddr1, md51, self.md5s2[faddr1])
result.append(faddr1)
return result

Expand Down