feat(NA) - Discard older metrics on buffer overflow.#10
Open
feat(NA) - Discard older metrics on buffer overflow.#10
Conversation
This tries to remove the oldest metric of the buffer once we reach max capacity and replace it with the new metrics instead of discarding those.
reistiago
suggested changes
Mar 9, 2017
Contributor
reistiago
left a comment
reistiago
left a comment
There was a problem hiding this comment.
I would really like to replace the exception based approach.
Thoughts?
| if (!inserted) { | ||
| try { | ||
| LOGGER.fine("Buffer is full, trying to discard oldest metric."); | ||
| aggregatedFreqBuffer.remove(); |
Contributor
There was a problem hiding this comment.
Instead of remove we could use pool ( https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ArrayBlockingQueue.html#poll() ) which would allow us to log the discarded metric if we wanted, which I think we want, and doesn't throw exception if it's empty - returns null).
Thinking out loud, should we drop more then one metric?
| if (!inserted) { | ||
| try { | ||
| LOGGER.fine("Buffer is full, trying to discard oldest metric."); | ||
| buffer.remove(); |
| } | ||
|
|
||
| @Test | ||
| public void shouldDiscardIfStandardBufferIsFull() { |
Contributor
There was a problem hiding this comment.
we should, somehow, test the behaviour of trying to empty it when it's empty, more so if we keep the current exception based implementation for when it's empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to remove the oldest metric of the buffer once we reach max capacity and replace it with the new metrics instead of discarding those.