Added onLoaded event as setting. Made context public#2
Open
jmbeach wants to merge 1 commit intostasilo:masterfrom
Open
Added onLoaded event as setting. Made context public#2jmbeach wants to merge 1 commit intostasilo:masterfrom
jmbeach wants to merge 1 commit intostasilo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made an onLoaded event in case someone wants an event to fire as soon as the song starts playing. I'd also suggest making the song auto-playing optional. I made context a public property of BeatDetector so that you can monitor the current time of the song.